chore: allow docker-host to be configurable #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobybellwood
reviewed
Jul 5, 2024
shreddedbacon
force-pushed
the
docker-host-override
branch
2 times, most recently
from
67a1960 to
aa22121
Compare
shreddedbacon
force-pushed
the
docker-host-override
branch
from
aa22121 to
9aa5286
Compare
tobybellwood
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the
DOCKER_HOSTin the container image so that it can be modified. Previously it was exported to a value in the entrypoint and unable to be changed.Also removes the two unused dockerfiles in the legacy to prevent confusion.