Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check usespot before applying replicas #341

Merged
merged 1 commit into from
Jul 29, 2024
Merged

fix: check usespot before applying replicas #341

merged 1 commit into from
Jul 29, 2024

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Jul 29, 2024 •
edited
Loading

Fix the check for adding replicas for production environments when spot is enabled

tobybellwood
tobybellwood approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice pickup by @rocketeerbkw

LGTM

@shreddedbacon shreddedbacon marked this pull request as ready for review July 29, 2024 07:57
@shreddedbacon shreddedbacon merged commit b7c63c1 into main Jul 29, 2024
2 checks passed
@shreddedbacon shreddedbacon deleted the fix-spot-replica-check branch July 29, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobybellwood tobybellwood tobybellwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shreddedbacon @tobybellwood