Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add legacy registry passthrough support #645

Merged
merged 1 commit into from
Mar 13, 2024
Merged

chore: add legacy registry passthrough support #645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions charts/lagoon-build-deploy/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ kubeVersion: ">= 1.23.0-0"

type: application

version: 0.26.3
version: 0.26.4

appVersion: v0.15.4
appVersion: v0.15.5

annotations:
artifacthub.io/changes: |
- kind: changed
description: added clusterroles for tasks and builds
description: added legacy registry passthrough support
3 changes: 3 additions & 0 deletions charts/lagoon-build-deploy/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,9 @@ spec:
{{- with .Values.timeoutForLongRunningTaskPods }}
- "--timeout-longrunning-task-pod-cleanup={{ . }}"
{{- end }}
{{- with .Values.unauthenticatedRegistry }}
- "--unauthenticated-registry={{ . }}"
{{- end }}
{{- with .Values.extraArgs }}
{{- toYaml . | nindent 8 }}
{{- end }}
Expand Down
4 changes: 4 additions & 0 deletions charts/lagoon-build-deploy/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ rabbitMQHostname: ""
rabbitMQPassword: ""
rabbitMQUsername: ""

# This is here due to the removal of the passthrough from core https://github.com/uselagoon/lagoon/pull/3659
# if you leveraged this value in your core, you should ensure you update your remotes with this value to reflect what you previously had provided in core
# unauthenticatedRegistry: registry.lagoon.svc:5000

# NOTE!! lagoon api/host/port values if left empty fall back to the task api/host/port values
# taskSSHHost/lagoonTokenHost is the hostname for the lagoon token service
# taskSSHHost will be deprecated in favor of lagoonTokenHost
Expand Down
Loading