feat: add api-sidecar internal handler #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobybellwood
force-pushed
the
sshkey-handler
branch
from
2733784 to
681a004
Compare
tobybellwood
changed the title
smlx
reviewed
Jun 19, 2024
| image: "{{ .Values.apiSidecarHandler.image.repository }}:{{ coalesce .Values.apiSidecarHandler.image.tag .Values.imageTag .Chart.AppVersion }}" | ||
| imagePullPolicy: {{ .Values.apiSidecarHandler.image.pullPolicy }} | ||
| ports: | ||
| - name: http-3333 |
There was a problem hiding this comment.
If this is only used by the other containers in the pod, you don't need to expose any ports. Instead you can listen on :3333 in the sidecar and then access localhost:3333 in the api.
tobybellwood
force-pushed
the
sshkey-handler
branch
from
fbc4423 to
44102dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the api sidecar added in uselagoon/lagoon#3662