refactor: convert uint flags to boolean, other fixes and improvements #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Checklist
Converts some previously uint value flags (0/1) that represent booleans to be actual booleans, and fixes the way the values are added to the inputs of the mutations to prevent them being added by default and only added if they're defined specifically (either as true, or as a specific
--flag=falsevalue.Additional fixes to the deploytarget list too to reduce how much data is returned, with new
--wideand--show-tokenflag. These commands are only supported forplatform-owner, just makes it easier to read the output.Also adds the new
adminrole support from Lagoon v2.20.0 to organization owners commands, so that admins can be managed via the CLI now along with previous owner and viewer roles.