Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating drush config to allow extra-dump command for max_allowed_packet #401

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

cdchris12
Copy link
Contributor

@cdchris12 cdchris12 commented Feb 11, 2022

We recently discovered that drush doesn't consume the MARIADB_MAX_ALLOWED_PACKET value, which can cause issues for environments with larger than usual tables. This PR adds that value to the drush.yml file, and adds a sane default of 64M which can be overwritten if needed.

@cdchris12 cdchris12 added the bug Something isn't working label Feb 11, 2022
@cdchris12 cdchris12 self-assigned this Feb 11, 2022
@tobybellwood tobybellwood changed the title Updating drush config to consume the MARIADB_MAX_ALLOWED_PACKET variable Updating drush config to allow extra-dump command for max_allowed_packet Mar 3, 2022
@tobybellwood
Copy link
Member

tobybellwood commented Mar 3, 2022

@cdchris12 I've changed this slightly to wrap the entire extra-dump option as a variable EXTRA_DUMP_CMD="--max_allowed_packet=64M" - this then allows it to entirely overridden downstream (e.g. in PostgreSQL), or modified to suit an individual project, who may wish for additional overrides etc

Note that to override it downstream, you need to set it to a space, not an empty string (or the var sub doesn't work)
i.e. ENV EXTRA_DUMP_CMD=" " in the cli.Dockerfile

I'll push that var into the postgres example to get the tests passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants