Invoke chmod once per directory to fix permissions #420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change proposed
I noticed that
fix-permissions
was traversing the file system twice to set the file mode bits on directories. We can set all file mode bits for both directories and files at the same time.We could select file mode letter capital X - see
chmod
man pageThis doesn't change build speed by much but I thought I'd share it anyway. It simplifies the permissions change using a common, long supported method.