Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add solr-9 compatible images #951

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Add solr-9 compatible images #951

merged 5 commits into from
Mar 19, 2024

Conversation

tobybellwood
Copy link
Member

@tobybellwood tobybellwood commented Mar 18, 2024

This PR adds Solr 9 images to lagoon-images.

There are a couple of notable changes from the 8.x images:

  • The solr-9-drupal image uses the search_api_solr 4.x branch jump-start directly, instead of a static import
  • The location of the docker scripts directory changed, so we introduced a switch to account for it in the custom solr-precreate command
  • We now set the SOLR_INSTALL_DIR variable in the drupal image to accommodate the search_api_solr deprecating it from solrcore.properties
  • The base image is slightly larger, due to Solr no longer using slim upstream images (confusingly, slim in solr images is now an image without solr modules 🤯

Other than that, the images are virtually identical. However, you may need to reindex or destroy/replace your core to upgrade from solr8 to solr9.

Sample project using this at lagoon-examples/drupal-solr@main...solr9

@tobybellwood tobybellwood requested a review from bomoko March 18, 2024 01:59
Copy link
Contributor

@bomoko bomoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just one comment, but given I don't see how we get to that issue, it's not a biggy.

images/solr/solr-recreate.sh Outdated Show resolved Hide resolved
@tobybellwood tobybellwood marked this pull request as ready for review March 19, 2024 02:37
@tobybellwood tobybellwood merged commit 6966fbd into main Mar 19, 2024
1 check passed
@tobybellwood tobybellwood deleted the solr-9 branch March 19, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants