Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Allow for empty variable values #196

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Conversation

CGoodwin90
Copy link
Contributor

@CGoodwin90 CGoodwin90 commented Nov 15, 2023

Updates the Variables tabs to allow for variables to be created/updated with no value defined.
Includes confirm pop-up when adding/updating variable to have a null value.

image

Displays empty variables with a Tag component:

image

@tobybellwood
Copy link
Member

This looks good for entering, but we need to consider how to display an empty var - having a dash may be confusing, but not sure what the alternatives are
image

@CGoodwin90
Copy link
Contributor Author

This looks good for entering, but we need to consider how to display an empty var - having a dash may be confusing, but not sure what the alternatives are image

Pulled in the Tag component from antd, thoughts?

image

Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, works well

@tobybellwood tobybellwood merged commit c1c77ec into main Nov 27, 2023
3 of 5 checks passed
@tobybellwood tobybellwood deleted the allow_empty_envs branch November 27, 2023 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants