Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix numerous errors #229

Merged
merged 1 commit into from
Mar 25, 2024
Merged

fix numerous errors #229

merged 1 commit into from
Mar 25, 2024

Conversation

DaveDarsa
Copy link
Contributor

Fixes:

  • UI key related render errors
  • Initial prop cancellation warning
  • Hard refresh when navigating to organizations
  • Deprecated keycloak constructor call
  • styled components transient prop errors

@shreddedbacon Keycloak is still using the same adapter pattern as before, only difference being the new Keycloak() constructor call.

tobybellwood
tobybellwood approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all makes sense, and all tests passing now

@tobybellwood tobybellwood merged commit 3368759 into main Mar 25, 2024
6 of 8 checks passed
@tobybellwood tobybellwood deleted the errors-on-dev/prod branch March 25, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobybellwood tobybellwood tobybellwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaveDarsa @tobybellwood