Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: organization admin support #262

Merged
merged 9 commits into from
Jul 4, 2024
Merged

feat: organization admin support #262

merged 9 commits into from
Jul 4, 2024

Conversation

shreddedbacon
Copy link
Member

WIP: initial support for uselagoon/lagoon#3733
!!! This will not work until the above PR is merged

@tobybellwood
Copy link
Member

This will need a little work - I couldn't add admins via the UI - but the underlying GraphQL in the API does work. Also, "admin" should be an option when editing roles via the UI as well as owner.

@shreddedbacon
Copy link
Member Author

This will need a little work - I couldn't add admins via the UI - but the underlying GraphQL in the API does work. Also, "admin" should be an option when editing roles via the UI as well as owner.

Yeah, I have no idea what I'm doing in the UI at this point, I just slapped this together as a starting point :D happy for someone to take it over, or ditch it entirely and start from scratch

@DaveDarsa
Copy link
Contributor

@shreddedbacon I take it a user is either an owner or an admin since passing both booleans to the mutation causes the admin to be set to null and owner to true

with that in mind, the checkboxes behave mutually exclusively ( checking one unchecks the other )

@shreddedbacon
Copy link
Member Author

shreddedbacon commented Jun 30, 2024

@shreddedbacon I take it a user is either an owner or an admin since passing both booleans to the mutation causes the admin to be set to null and owner to true

with that in mind, the checkboxes behave mutually exclusively ( checking one unchecks the other )

Can you make it a dropdown box with 3 options ?

  • if OWNER is selected, then set the owner bit
  • if ADMIN is selected, set the admin bit
  • if VIEWER is selected, set nothing

@shreddedbacon
Copy link
Member Author

image
Yeah, this is heaaapps better 🥳

@shreddedbacon shreddedbacon added this to the 2.20.0 milestone Jul 4, 2024
@DaveDarsa DaveDarsa marked this pull request as ready for review July 4, 2024 07:37
@DaveDarsa DaveDarsa merged commit 1531166 into main Jul 4, 2024
6 of 8 checks passed
@DaveDarsa DaveDarsa deleted the organization-admin branch July 4, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants