Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: invite user checkbox for add user modals #283

Merged
merged 1 commit into from
Jul 5, 2024
Merged

feat: invite user checkbox for add user modals #283

merged 1 commit into from
Jul 5, 2024

Conversation

DaveDarsa
Copy link
Contributor

closes #282

tobybellwood
tobybellwood approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected, nice!

@tobybellwood tobybellwood merged commit 17843f4 into main Jul 5, 2024
6 of 8 checks passed
@tobybellwood tobybellwood deleted the invite-user branch July 5, 2024 00:32
@shreddedbacon
Copy link
Member

shreddedbacon commented Jul 10, 2024 •
edited
Loading

ahh, i think the wording on this should have been like "Invite user to Lagoon"?

image

edit: maybe its fine, but it just reads a bit weird

@DaveDarsa
Copy link
Contributor Author

ahh, i think the wording on this should have been like "Invite user to Lagoon"?

image

edit: maybe its fine, but it just reads a bit weird

yeah, could be confusing - change coming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobybellwood tobybellwood tobybellwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding a user to a group should offer the option to create user if non-existent
3 participants
@DaveDarsa @shreddedbacon @tobybellwood