Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixes SSHKey modal #290

Merged
merged 4 commits into from
Aug 5, 2024
Merged

Fix: Fixes SSHKey modal #290

merged 4 commits into from
Aug 5, 2024

Conversation

CGoodwin90
Copy link
Contributor

@CGoodwin90 CGoodwin90 commented Jul 25, 2024

Fixes global styling on the antd modal to allow dark mode to work properly & populates the existing key in the modal. Also adds an error notification instead of rendering a div with the error message, adds a delete confirmation & updates relevant tests.

image

closes #289

@CGoodwin90 CGoodwin90 requested a review from DaveDarsa July 25, 2024 05:07
@CGoodwin90 CGoodwin90 removed the request for review from DaveDarsa July 25, 2024 08:48
@CGoodwin90 CGoodwin90 marked this pull request as ready for review July 26, 2024 07:36
@CGoodwin90 CGoodwin90 requested a review from DaveDarsa July 26, 2024 07:36
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and does as expected.

@tobybellwood tobybellwood merged commit b0b8a22 into main Aug 5, 2024
4 checks passed
@tobybellwood tobybellwood deleted the sshkey-modal-fix branch August 5, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit SSH Key modal in darkmode
3 participants