Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch names with slash don't work in active/standby #3212

Closed
shreddedbacon opened this issue Jul 15, 2022 · 0 comments · Fixed by #3214
Closed

Branch names with slash don't work in active/standby #3212

shreddedbacon opened this issue Jul 15, 2022 · 0 comments · Fixed by #3214

Comments

@shreddedbacon
Copy link
Member

Describe the bug

When creating a project to use active/standby, if my production and standby production environments have / in the name, when triggering an active/standby it fails.

To Reproduce

Steps to reproduce the behavior:

  1. Create a branch called prod/left and deploy it as productionEnvironment
  2. Create a branch called prod/right and deploy it as standbyProductionEnvironment
  3. Check the UI to see that both environments are production type
  4. See in the UI that they are missing the active and standby labels
  5. Attempt to trigger the active/standby switch directly with the API (as the UI button is not available)
  6. Get an error

Expected behavior

Be able to trigger the switch without issue

Additional context

We do checks with environment by name, but due to #2322 it doesn't work correctly

@shreddedbacon shreddedbacon changed the title Branch names with / don't work in active/standby Branch names with slash don't work in active/standby Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant