Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Completed with Warnings" to CLI and Notification output #3819

Closed
tobybellwood opened this issue Oct 8, 2024 · 1 comment · Fixed by #3821 or uselagoon/lagoon-cli#388
Closed
Assignees

Comments

@tobybellwood
Copy link
Member

Currently users who don't use the CLI will have no idea (without looking at the logs) that their successful build has failed with warnings. +1 if we could include "why the build failed"

@shreddedbacon shreddedbacon self-assigned this Oct 9, 2024
@shreddedbacon
Copy link
Member

shreddedbacon commented Oct 9, 2024

+1 if we could include "why the build failed"

This is only currently possible by parsing the build log, as there are no stages saved against the API, just the final stage/step

Also small clarification around the wording used. completed with warnings are not failures. The build step can show which step builds failed at though, but not which warnings were collected, this would require changes to the API to store this information better. CLI and Logs2Notifications would need to parse the log to extract this information, which would be duplicated processes, want to avoid that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants