feat: update notifications with more information for build states #3821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
force-pushed
the
notification-build-warnings
branch
from
4718934 to
4bb4548
Compare
tobybellwood
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Checklist
Database Migrations
Updates the notification service to produce warning message if a build reaches the state of
complete with warningsand indicates that the build completed with warnings and to check the logs for further information.Additionally, if a build fails, the step at which it failed will be included in the notification now.
For the
webhooktype notifications, failures also include thebuildStepat which it failed. Completed webhook notifications include a new fieldwarning: trueif the build has warnings.Closing issues
closes #3819