Additional SSH service changes #2881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n2 now, move k8s label selector first, and fall back to openshift. adjust interval to 5s instead of 1s, but retain the same total duration
|
@shreddedbacon |
Yeah, I'm looking at that now |
|
I've added a specific branch for v2.0.0 of lagoon where the environment defined openshift reference doesn't exist here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Try to reduce the number of API calls that are made to the targeted cluster.
Prefer Kubernetes targets first with the
lagoon.sh/servicelabels, as Openshift 3.11 clusters are nearly non-existent.Don't even try Openshift if a Kuberenetes is targeted.