Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: populate the values.yaml for fastly ingress support #2921

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

shreddedbacon
Copy link
Member

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

As explained in #2848 ingresses get double applied. Which for adding fastly annotations to autogenerated routes means that the changes are added, but the second apply wipes the changes out.

This adds the fastly.x values to the main values.yaml file that is consumed again later on by the secondary apply.

Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - can confirm that autogen routes now get fastly if needed

    lagoon.sh/autogenerated: "true"
...
    fastly.amazee.io/service-id: newlagoon
    fastly.amazee.io/watch: "true"

@tobybellwood tobybellwood merged commit 285cb61 into main Nov 10, 2021
@tobybellwood tobybellwood deleted the autogen-fastly-routes branch November 10, 2021 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants