Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error running addKubernetes with empty id #2929

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Fix error running addKubernetes with empty id #2929

merged 1 commit into from
Nov 29, 2021

Conversation

rocketeerbkw
Copy link
Member

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

There was a SQL error related to the API resolver not defaulting the id to null. This PR removes the stored procedure to pass the inputs directly.

Closing issues

closes #2755

@rocketeerbkw rocketeerbkw added the 1-api-auth API & Authentication subsystem label Nov 12, 2021
@rocketeerbkw rocketeerbkw added this to the v2.x milestone Nov 12, 2021
@tobybellwood tobybellwood modified the milestones: v2.x, v2.4.0 Nov 22, 2021
@tobybellwood tobybellwood merged commit 378bb8f into main Nov 29, 2021
@tobybellwood tobybellwood deleted the 2755-fix-addKubernetes-no-id branch November 29, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1-api-auth API & Authentication subsystem
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.

addKubernetes/addOpenshift without ID fails
2 participants
@rocketeerbkw @tobybellwood