-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating advanced task resolver and permissions #2955
Merged
timclifford
merged 20 commits into
feature/workflows
from
workflows/taskDefinitionResolvers
Dec 16, 2021
Merged
updating advanced task resolver and permissions #2955
timclifford
merged 20 commits into
feature/workflows
from
workflows/taskDefinitionResolvers
Dec 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bomoko
requested changes
Dec 5, 2021
project | ||
); | ||
|
||
const systemLevelTask = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I'm thinking about this part of the code. I think what we need to do is refactor this stuff and encapsulate a lot of this logic into either functions or classes.
…nto workflows/taskDefinitionResolvers
timclifford
force-pushed
the
workflows/taskDefinitionResolvers
branch
from
December 14, 2021 16:51
517c746
to
df7fb77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Explain the details for making this change. What existing problem does the pull request solve?
Closing issues
Put
closes #XXXX
in your comment to auto-close the issue that your PR fixes (if such).