Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating advanced task resolver and permissions #2955

Merged
merged 20 commits into from
Dec 16, 2021

Conversation

timclifford
Copy link
Contributor

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

Explain the details for making this change. What existing problem does the pull request solve?

Closing issues

Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

@timclifford timclifford requested a review from bomoko December 3, 2021 16:42
project
);

const systemLevelTask =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I'm thinking about this part of the code. I think what we need to do is refactor this stuff and encapsulate a lot of this logic into either functions or classes.

@timclifford timclifford force-pushed the workflows/taskDefinitionResolvers branch from 517c746 to df7fb77 Compare December 14, 2021 16:51
@timclifford timclifford merged commit 2f3dc1c into feature/workflows Dec 16, 2021
@timclifford timclifford deleted the workflows/taskDefinitionResolvers branch December 16, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants