implement kubectl check for lagoon-build and add more tests #3039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobybellwood
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a kubectl check for a lagoon-build pod whenever a branch is deployed. It performs a first check to get the name of the started pod, and then follows that pod until it reaches a "completed" status, before handing back to the ansible task that called it. This completely removes the need for the 30/90 retries we used to check if a service has been deployed.
There are still some tidyups to do - removing a lot of the cruft around retries and loops etc.
In additon, a couple of additional tests have been added (dbaas and generic), and some other tidyups happened.