Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

environment_fact table updates - service column and unique constraint #3064

Merged

Conversation

timclifford
Copy link
Contributor

@timclifford timclifford commented Mar 14, 2022

This PR updates the environment_fact table to add a column for "service" to store the lagoon service that the fact relates to.

It also adds an additional migration to modify the uniqueness constraint for that table to accomodate the concept of multiple services returning similar facts (as with Drupal -which reports in the cli, nginx and php services usually)

@timclifford timclifford requested a review from bomoko March 14, 2022 11:02
@tobybellwood tobybellwood changed the title Adding service column to environment fact environment_fact table updates - service column and unique constraint Mar 15, 2022
Copy link
Contributor

@bomoko bomoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobybellwood tobybellwood merged commit 22adede into main Mar 15, 2022
@tobybellwood tobybellwood deleted the feature/api-fact-table-uniqueness-with-service-column branch March 15, 2022 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants