Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: logs2notifications #3077

Merged
merged 26 commits into from
Sep 2, 2022
Merged

Feature: logs2notifications #3077

merged 26 commits into from
Sep 2, 2022

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Mar 23, 2022

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

This change adds logs2notifications service to Lagoon. It replaces the existing logs2slack, logs2rocketchat, logs2microsoftteams, logs2webhooks, and logs2email services.

Currently the logs2x services all consume from individual queues, each service will then check the API for its specific notification types for the project/environment the logs is associated to, and then process the message according. This is currently 5 API requests for each message received, adding unnecessary load on the API in a busy Lagoon.

The new notifications system does this a little bit differently and processes from one queue only, then checks the API for each message for all the notification types available to that project, this is just one API request. Then it sends the message to the appropriate message handler service within logs2notifications.

The logs2s3 system is also consolidated into the system as it functions in a similar way to other notifications systems, while not being notifications like slack, or the other types.

@shreddedbacon shreddedbacon changed the title WIP: logs2notifications Feature: logs2notifications Jul 25, 2022
@shreddedbacon shreddedbacon marked this pull request as ready for review July 26, 2022 02:12
@tobybellwood
Copy link
Member

We'll need to make sure that these workspaces are removed from yarn.lock

@rocketeerbkw
Copy link
Member

Instructions for cleaning up yarn #1798 (comment)

@shreddedbacon
Copy link
Member Author

This has been running in the test infrastructure for a couple of days and everything is working as expected with notifications 🥳

Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works - lets begin the process to get it merged!

@tobybellwood tobybellwood merged commit 944f1e3 into main Sep 2, 2022
@tobybellwood tobybellwood deleted the logs2notifications branch September 2, 2022 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants