-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: logs2notifications #3077
Conversation
We'll need to make sure that these workspaces are removed from yarn.lock |
Instructions for cleaning up yarn #1798 (comment) |
This has been running in the test infrastructure for a couple of days and everything is working as expected with notifications 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this works - lets begin the process to get it merged!
Checklist
This change adds logs2notifications service to Lagoon. It replaces the existing logs2slack, logs2rocketchat, logs2microsoftteams, logs2webhooks, and logs2email services.
Currently the logs2x services all consume from individual queues, each service will then check the API for its specific notification types for the project/environment the logs is associated to, and then process the message according. This is currently 5 API requests for each message received, adding unnecessary load on the API in a busy Lagoon.
The new notifications system does this a little bit differently and processes from one queue only, then checks the API for each message for all the notification types available to that project, this is just one API request. Then it sends the message to the appropriate message handler service within logs2notifications.
The
logs2s3
system is also consolidated into the system as it functions in a similar way to other notifications systems, while not being notifications like slack, or the other types.