feature: add a timeout on the rollout status watch #3089
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Sometimes
kubectl rollout status
can get stuck indefinitely waiting for a rollout to complete due to an issue with the previous pod in the existing replicaset possibly not terminating.Adding a
--timeout=1200s
to this status check is double what theprogressDeadlineSeconds
value is, and if a pod rollout is taking more than 20 minutes to complete, there is probably something wrong anyway.Closing issues
Partially closes #2861 as it won't actually report on a long running notification, but will prevent the condition where a long running deployment would occur. With intermittent build logs now, it can be more obvious where a build has stalled, before calling it "long running"