-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: API changes to support cancelling tasks #3112
Conversation
I like, but theres some things I think we can do better to better handle cancelling tasks (the controller needs to be updated too, but we should add the initial support into core before we expose task cancelling in the api) |
Would close #3106 |
Now that the controller can cancel tasks - the approach needs revisiting. @shreddedbacon to assess refactor/rewrite |
e491d84
to
c0b6277
Compare
c0b6277
to
a38128c
Compare
9e144e4
to
5d97468
Compare
5d97468
to
e4acd0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and should all work - just added a couple comments/questions. Nice PR!
6203b99
to
1038056
Compare
Checklist
This adds support to the API to be able to cancel tasks. There is a permission split to do by production and development environment, and the roles are configured by default to be
developer
can cancel development environment tasks, andmaintainer
can cancel production and development environment tasks.The cancelTask mutation can be called like so
Changes to the UI will be required to support the cancellation of tasks in https://github.com/uselagoon/lagoon-ui
Closing issues
closes #3106