fix errors in migrations sql #3120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in #3117 we fixed the column type lookup, but not the redefined type which still included the errant space (again, as per the original PR, I've modified the unreleased migration)
Additionally, in #3094 we added a migration to update a table, but inadvertently added the new column to the wrong table. I've modified the migration here (instead of adding a new one), as it'll not trigger currently (as the wrong table was updated). Arguably we could add another migration to remove the errant column, but we'll do that separately as part of a larger cleanup
Also added in a missed call from #3114 to enable the new tasks setup (again unreleased)
+1 to any suggestions for a
migrationstesting framework (see #3058 for more wildness)