feat: use build tool to generate ingress templates #3133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
shreddedbacon
force-pushed
the
route-generation-v2
branch
from
ac88100 to
b37b91b
Compare
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
The way ingress templates are created using bash can be slow, using this new tool to handle the templating is significantly faster for environments that have a lot of ingress objects. It doesn't use helm to generate the templates.
Example, a project with 1500 ingress(!!) can take hours with the previous bash because of all the underlying calls to
shyaml. With this tool it can do the templating for the same ingress objects in under 10s (applying them is another story)This only handle custom-ingress for the time being,
autogeneratedroutes are still handled with bash and helm templates.Tool code lives here for the time being: https://github.com/uselagoon/build-deploy-tool