Replace pre and post-rollout tasks bash scripts with build-deploy-tool #3146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanhamlin
reviewed
May 22, 2022
seanhamlin
reviewed
May 22, 2022
Changing when example to reference LAGOON_ENVIRONMENT_TYPE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of build-deploy-tool version 0.8.1 we have support for pre and post rollout tasks.
This PR replaces the existing bash implementation of the task runner with an almost one-for-one replacement of the existing bash, differing only in supporting the new "when" functionality for lagoon tasks.
The possibility of running tasks conditionally has been discussed in issue #1648 - and with the new Bulk Deploy functionality that has been introduced, with the possibility of injecting arbitrary build time arguments, better support for conditionals is called for.
Checklist
Closing issues
closes #1648