Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updateEnvironment environment type check #3199

Merged
merged 1 commit into from
Jun 30, 2022
Merged

fix: updateEnvironment environment type check #3199

merged 1 commit into from
Jun 30, 2022

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Jun 23, 2022 •
edited
Loading

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

The updateEnvironment resolver was using environment_type instead of environmentType as a fallback value in part of a permission check. It seems it was missed as part of #2632 Seems like it has existed since forever

@tobybellwood tobybellwood merged commit 1d8fd66 into main Jun 30, 2022
@tobybellwood tobybellwood deleted the updateenv-resolver-fix branch June 30, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shreddedbacon @tobybellwood