Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Set podsecuritycontext values for openshift to supplemental group id #3228

Merged
merged 5 commits into from
Jul 27, 2022
Merged

Fix: Set podsecuritycontext values for openshift to supplemental group id #3228

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1bb32ab
chore: unset podsecuritycontext values in openshift
shreddedbacon Jul 26, 2022
3720a17
fix: add the file
shreddedbacon Jul 26, 2022
81163f3
chore: try supplemental group
shreddedbacon Jul 26, 2022
2470106
chore: echo the group
shreddedbacon Jul 26, 2022
41457c1
chore: revert values file changes only use supplemental group
shreddedbacon Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions images/kubectl-build-deploy-dind/build-deploy-docker-compose.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,6 +748,14 @@ set +x
if [ "$(featureFlag ROOTLESS_WORKLOAD)" = enabled ]; then
yq3 merge -ix -- /kubectl-build-deploy/values.yaml /kubectl-build-deploy/rootless.values.yaml
fi

if [ "${SCC_CHECK}" != "false" ]; then
# openshift permissions are different, this is to set the fsgroup to the supplemental group from the openshift annotations
# this applies it to all deployments in this environment because we don't isolate by service type its applied to all
OPENSHIFT_SUPPLEMENTAL_GROUP=$(kubectl get namespace ${NAMESPACE} -o json | jq -r '.metadata.annotations."openshift.io/sa.scc.supplemental-groups"' | cut -c -10)
echo "Setting openshift fsGroup to ${OPENSHIFT_SUPPLEMENTAL_GROUP}"
yq3 write -i -- /kubectl-build-deploy/values.yaml 'podSecurityContext.fsGroup' $OPENSHIFT_SUPPLEMENTAL_GROUP
fi
set -x


Expand Down