Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: add image size information for built images #3232

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Feature: add image size information for built images #3232

merged 1 commit into from
Jul 27, 2022

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Jul 27, 2022 •
edited
Loading

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Display information about image sizes in builds:

##############################################
Built image sizes:
##############################################
Image ci-nginx-control-k8s-nginx-nginx		119MB
Image ci-nginx-control-k8s-nginx-nginx-basic-auth		119MB
Image ci-nginx-control-k8s-nginx-nginx-basic-auth-disable		119MB

Closing issues

closes #3224

@shreddedbacon shreddedbacon marked this pull request as ready for review July 27, 2022 06:18
@tobybellwood tobybellwood self-requested a review July 27, 2022 07:45
tobybellwood
tobybellwood reviewed Jul 27, 2022
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this is good enough for now. Will have to rework in golang, but meets the brief!

@tobybellwood tobybellwood merged commit 111e147 into main Jul 27, 2022
@tobybellwood tobybellwood deleted the image-sizes branch July 27, 2022 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobybellwood tobybellwood tobybellwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Output the size of the images being pushed to the image registry in the build process
2 participants
@shreddedbacon @tobybellwood