Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use restore bucket protocol from the restore url #3252

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

shreddedbacon
Copy link
Member

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

When working locally if a restore is in a local minio for example, the minio may not have https on it. As https is hardcoded, the restore fails to work, instead use the protocol from the restore itself.

@shreddedbacon shreddedbacon marked this pull request as ready for review August 12, 2022 06:51
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested local and in test cluster

@tobybellwood tobybellwood merged commit d9bccdc into main Aug 12, 2022
@tobybellwood tobybellwood changed the title fix: use protocol from the restore url fix: use restore bucket protocol from the restore url Aug 12, 2022
@tobybellwood tobybellwood deleted the fix-restore-url-protocol branch August 26, 2022 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants