Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use deploytarget instead of kubernetes for message key #3361

Merged
merged 4 commits into from
Jul 18, 2023
Merged

refactor: use deploytarget instead of kubernetes for message key #3361

merged 4 commits into from
Jul 18, 2023

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Dec 5, 2022 •
edited
Loading

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Now that uselagoon/remote-controller#195 has been released for some time, this is just fixing up lagoon-core to use the new keys that reference deploytarget instead of kubernetes

@shreddedbacon shreddedbacon changed the title WIP: use deploytarget instead of kubernetes for key refactor: use deploytarget instead of kubernetes for key Jun 21, 2023
@shreddedbacon shreddedbacon added this to the 2.16.x milestone Jun 21, 2023
@shreddedbacon shreddedbacon changed the title refactor: use deploytarget instead of kubernetes for key refactor: use deploytarget instead of kubernetes for message key Jun 21, 2023
@shreddedbacon shreddedbacon marked this pull request as ready for review June 21, 2023 09:15
@shreddedbacon shreddedbacon modified the milestones: 2.16.x, 2.15.3 Jul 18, 2023
@tobybellwood tobybellwood merged commit a2a4b77 into main Jul 18, 2023
@tobybellwood tobybellwood deleted the misc-keys branch July 18, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.15.3
Development

Successfully merging this pull request may close these issues.
2 participants
@shreddedbacon @tobybellwood