refactor: check if retries are required on some errors #3471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
force-pushed
the
actions-updates
branch
from
d6d563b to
6774638
Compare
bomoko
approved these changes
Jul 11, 2023
It is possible, but only if the errors that are returned are consistently reset by peer errors. Which from analysing logs only happens during scaling events where the API pod becomes unavailable mid request, that is basically the protection this is covering for. |
|
sweet, happy happy - LGTM and all that jazz. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If the lagoon-api is unresponsive, sometimes the actions-handler is unable to update properly. This adds error checking that if a connection reset is hit (api down) then it will flag an error and the message will remain in the queue to be retried again.
An example of a connection reset is below. This message was dropped, which means the status of this deployment may not have been updated correctly because the message is dropped when this error is hit.