Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use projectid in the addfactsbyname permission check #3486

Merged
merged 1 commit into from
Jul 20, 2023
Merged

fix: use projectid in the addfactsbyname permission check #3486

merged 1 commit into from
Jul 20, 2023

Conversation

shreddedbacon
Copy link
Member

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Quick fix to the permission check to use the project ID rather than the project name from the input.

@shreddedbacon shreddedbacon marked this pull request as ready for review July 19, 2023 23:07
@shreddedbacon shreddedbacon added this to the 2.15.3 milestone Jul 19, 2023
@shreddedbacon shreddedbacon requested a review from bomoko July 19, 2023 23:07
@shreddedbacon shreddedbacon changed the title fix: use the id in the permission check fix: use projectid in the addfactsbyname permission check Jul 19, 2023
tobybellwood
tobybellwood approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems straightforward

@tobybellwood tobybellwood merged commit 292fe42 into main Jul 20, 2023
@tobybellwood tobybellwood deleted the factsbynamefix branch July 20, 2023 02:28
bomoko
bomoko reviewed Jul 20, 2023
View reviewed changes
Copy link
Contributor

@bomoko bomoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bomoko bomoko bomoko left review comments

@tobybellwood tobybellwood tobybellwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.15.3
Development

Successfully merging this pull request may close these issues.
3 participants
@shreddedbacon @bomoko @tobybellwood