Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: reduce user queries to keycloak #3517

Merged
merged 1 commit into from
Aug 31, 2023
Merged

refactor: reduce user queries to keycloak #3517

merged 1 commit into from
Aug 31, 2023

Conversation

shreddedbacon
Copy link
Member

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

This removes a step to query keycloak for user information when the information required is already in the payload from the listMembers query.

@shreddedbacon shreddedbacon marked this pull request as ready for review August 11, 2023 07:38
@shreddedbacon shreddedbacon requested a review from bomoko August 14, 2023 05:53
@shreddedbacon shreddedbacon added this to the 2.16.x milestone Aug 30, 2023
tobybellwood
tobybellwood approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested working

@tobybellwood tobybellwood merged commit 31b6722 into main Aug 31, 2023
@shreddedbacon shreddedbacon deleted the reduce-keycloak-user-queries branch December 11, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobybellwood tobybellwood tobybellwood approved these changes

@bomoko bomoko Awaiting requested review from bomoko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.16.x
Development

Successfully merging this pull request may close these issues.
2 participants
@shreddedbacon @tobybellwood