Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: permission changes for some organization changes #3539

Merged
merged 2 commits into from
Sep 7, 2023
Merged

fix: permission changes for some organization changes #3539

merged 2 commits into from
Sep 7, 2023

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Sep 6, 2023 •
edited
Loading

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Small fix to the way the viewUser permission is checked in organizations, and the permission around addOwner and addViewer

@shreddedbacon shreddedbacon marked this pull request as ready for review September 6, 2023 08:53
@shreddedbacon shreddedbacon changed the title fix: viewuser permission in organizations fix: permission changes for some organization changes Sep 6, 2023
tobybellwood
tobybellwood approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobybellwood tobybellwood merged commit 35629b1 into main Sep 7, 2023
@tobybellwood tobybellwood deleted the fix-viewuser-permission branch September 7, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobybellwood tobybellwood tobybellwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shreddedbacon @tobybellwood