Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: flag to support adding orgowner as owner of project or group on creation #3540

Merged
merged 2 commits into from
Sep 12, 2023
Merged

refactor: flag to support adding orgowner as owner of project or group on creation #3540

merged 2 commits into from
Sep 12, 2023

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Sep 6, 2023 •
edited
Loading

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

This adds a boolean organizationProjectOwner to addProject that if set to true will add the organization owner to the newly created project

@shreddedbacon shreddedbacon changed the title refactor: add opt-in flag to add the organization owner to project refactor: flag to support adding orgowner as owner of project on creation Sep 10, 2023
@shreddedbacon shreddedbacon marked this pull request as ready for review September 10, 2023 22:50
@tobybellwood
Copy link
Member

tobybellwood commented Sep 11, 2023 •
edited by shreddedbacon
Loading

to-do:

  • add similar BE functionality for an orgowner creating a group

@shreddedbacon shreddedbacon changed the title refactor: flag to support adding orgowner as owner of project on creation refactor: flag to support adding orgowner as owner of project or group on creation Sep 11, 2023
tobybellwood
tobybellwood approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gives us flexibility here, LGTM

@tobybellwood tobybellwood merged commit f619678 into main Sep 12, 2023
@tobybellwood tobybellwood deleted the org-project-owner-optin branch September 12, 2023 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobybellwood tobybellwood tobybellwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shreddedbacon @tobybellwood