Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: deploytargetconfig permission for projects in organizations #3558

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

shreddedbacon
Copy link
Member

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

Changes the permission for projects that are in organizations to allow only organization owners the permission to add or modify deploytarget configs. This is because organizations have deploytargets assigned to them, and organization owners should be able to restrict where projects deploy their environments to from the targets assigned to the organization.

The behavior remains the same for projects not in an organization, where anyone with the permission to update a project can add or modify.

Closing issues

Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

…nfigs for organization owners only if project is in organization
@shreddedbacon shreddedbacon added this to the 2.16.x milestone Oct 5, 2023
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally, working

@tobybellwood tobybellwood merged commit 05d1505 into main Oct 8, 2023
@shreddedbacon shreddedbacon deleted the organization-deploytarget-configs branch December 11, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants