Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: Updates Organization Groups #3563

Merged
merged 6 commits into from
Oct 11, 2023
Merged

Change: Updates Organization Groups #3563

merged 6 commits into from
Oct 11, 2023

Conversation

CGoodwin90
Copy link
Contributor

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Adds Organization specific input & type for Organization Groups.

@CGoodwin90 CGoodwin90 mentioned this pull request Oct 10, 2023
Merged
@CGoodwin90 CGoodwin90 marked this pull request as ready for review October 10, 2023 06:51
shreddedbacon
shreddedbacon requested changes Oct 10, 2023
View reviewed changes
Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The typedef for getGroupProjectOrganizationAssociation needs to be updated to use AddGroupToOrganizationInput

@shreddedbacon shreddedbacon self-requested a review October 10, 2023 23:59
shreddedbacon
shreddedbacon approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all seems to work well. Again as organizations isn't released yet these changes make sense to do now

@tobybellwood tobybellwood merged commit 3873114 into main Oct 11, 2023
@tobybellwood tobybellwood deleted the group_org_update branch October 11, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreddedbacon shreddedbacon shreddedbacon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CGoodwin90 @shreddedbacon @tobybellwood