Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check environment doesnt exist before checking env quotas #3567

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

shreddedbacon
Copy link
Member

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

Fixes the environment quota check to make sure that an environment that already exists isn't evaluated to check if the quota is exceeded, and to allow it through as normal.

Also modifies the example organization deployed in local dev with a 4 env quota to validate

@shreddedbacon shreddedbacon marked this pull request as ready for review October 13, 2023 00:16
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward change. A++ for test consideration

@tobybellwood tobybellwood merged commit 083aa40 into main Oct 15, 2023
@tobybellwood tobybellwood deleted the environment-quota-fix branch October 15, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants