Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js version to 20, yarn fix vulnerabilites and update typescript #3582

Merged
merged 7 commits into from
Nov 15, 2023

Conversation

tobybellwood
Copy link
Member

@tobybellwood tobybellwood commented Oct 31, 2023

This PR takes a number of actions:

  • Updates the Node.js version of the images to Node 20
  • Updates a couple of dependencies with vulnerability-fixed versions (axios, amqplib)
  • Runs yarn-audit-fix to remedy any other fixable vulnerabilities in dependencies.
  • Upgrades all Typescript to the same version for all workspaces
  • Pins Ramda to 0.25.0 for now to avoid a nasty regression with newer Typescript checks
  • Adds two ts-ignore statements for Typescript errors that need rectifying (I'm a 🤷 on that one)
                      │               Analyzed Image               │              Comparison Image               
  ────────────────────┼────────────────────────────────────────────┼─────────────────────────────────────────────
    Target            │  testlagoon/api:pr-3582                    │  uselagoon/api:v2.16.0                      
      digest          │  f4cc8df043ee                              │  36530b03d397                               
      platform        │ linux/amd64                                │ linux/amd64                                 
      provenance      │ https://github.com/uselagoon/lagoon.git    │ https://github.com/uselagoon/lagoon.git     
                      │  453d7e1bdb2b74b4caa1c3d2d71f350340807fd6  │  083aa40a8704b327c4cb7ba92cf83ad6a211aaf2   
      vulnerabilities │   15C    72H    64M     3L     4?          │   20C    87H    78M     4L    10?           
                      │    -5    -15    -14     -1     -6          │                                             
      size            │ 152 MB (+286 kB)                           │ 152 MB                                      
      packages        │ 1664 (+72)                                 │ 1592                                        
                      │                                            │                                             
    Base image        │  node:20-alpine                            │  node:16-alpine                             
      tags            │ also known as                              │ also known as                               
                      │   • 20-alpine3.18                          │                                             
                      │   • alpine                                 │                                             
                      │   • alpine3.18                             │                                             
                      │   • current-alpine                         │                                             
                      │   • current-alpine3.18                     │                                             
      vulnerabilities │    0C     0H     0M     0L     1?          │    0C     0H     1M     0L     1?    
      ```

@tobybellwood tobybellwood marked this pull request as ready for review November 1, 2023 01:47
@tobybellwood tobybellwood merged commit 9e96d2f into main Nov 15, 2023
@tobybellwood tobybellwood deleted the testing/yarn_audit_fix_oct23 branch November 15, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants