-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rewrite activestandby task to remove external dioscuri requirement #3592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for old task data
tobybellwood
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this from my side. It'll be good to get it into test infra against previously migrated routes to confirm.
This will need an entry in deprecations.md to signal the removal of disocuri as an external dependency.
shreddedbacon
commented
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Checklist
Database Migrations
The existing activestandby task has a heavy dependence on dioscuri which is becoming difficult to maintain.
The goal of this task is to incorporate the functionality of dioscuri into the activestandby task that Lagoon performs. Initial support was rolled into the
remote-controller
under uselagoon/remote-controller#148 which allows for this new task to do the functions it needs between the two namespaces.What this task also does is replace the older labels on ingress from
dioscuri.amazee.io
toactivestandby.lagoon.sh
.Also new, is when the migrations are being performed, it will add a new label
activestandby.lagoon.sh/migrating=true
to indicate that the migration is taking place. Once the migration has taken place, it sets it tofalse
. This is so that other systems that may look at ingress and perform functions can potentially use this new label to take action on something, or prevent something from happening when the ingress are moved between namespaces.Note: This has a dependency on
remote-controller v0.15.4
, which is contained inlagoon-remote 0.86.1
or greater.Closing issues
closes #2607