Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds service to deleteFactsFromSource #3627

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

bomoko
Copy link
Contributor

@bomoko bomoko commented Dec 17, 2023

This PR introduces the same functionality as an earlier PR #2611

The rationale for its existence mirrors that of the earlier PR, but mutatis mutandis wrt facts.

Essentially, it allows us to better target facts for clearing, since multiple facts could potentially exist with the same name, same source, but on different services.

Think, for instance, a php-version collected by some process that runs on both the php-nginx service and a cli service, we want to be able to clear the facts from one of the services, without having it be cleared from both.

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

@shreddedbacon shreddedbacon added this to the 2.18.0 milestone Jan 17, 2024
@shreddedbacon
Copy link
Member

Good to merge from my perspective, this just extends an existing mutations input without any breaking changes, and the logic contained within appears sound for the description provided.

@tobybellwood tobybellwood merged commit 7dfbaa4 into main Feb 6, 2024
1 check passed
@tobybellwood tobybellwood deleted the feature/add_service_to_deleteFactsFromSource branch March 13, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants