Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add correct roles and scopes to keycloak account client realm import #3655

Merged
merged 2 commits into from
Feb 23, 2024
Merged

fix: add correct roles and scopes to keycloak account client realm import #3655

merged 2 commits into from
Feb 23, 2024

Conversation

shreddedbacon
Copy link
Member

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

Just fixes the realm import for initial installs to import the roles and scopes for the account client to allow users to access their profile page in the keycloak UI.

Prior to this, if a user went to Your account from the Lagoon UI and clicked on anything to edit their account it would give a permission denied. This fixes that by importing a known export of the roles and scopes.

@shreddedbacon shreddedbacon added this to the 2.18.0 milestone Feb 21, 2024
@shreddedbacon shreddedbacon force-pushed the keycloak-realm-import-account branch from a31f12b to 973028c Compare February 21, 2024 07:47
@shreddedbacon shreddedbacon changed the title fix: add account client with roles to import to fix user profile page access fix: add correct roles and scopes to account client Feb 21, 2024
@shreddedbacon shreddedbacon changed the title fix: add correct roles and scopes to account client fix: add correct roles and scopes to keycloak account client Feb 21, 2024
@shreddedbacon shreddedbacon force-pushed the keycloak-realm-import-account branch from 973028c to d22dcd3 Compare February 21, 2024 07:48
@shreddedbacon shreddedbacon marked this pull request as ready for review February 21, 2024 07:49
tobybellwood
tobybellwood approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gone through this and all makes sense. Nice pickup on the random s/maintainer/guest mismatch.

@tobybellwood tobybellwood changed the title fix: add correct roles and scopes to keycloak account client fix: add correct roles and scopes to keycloak account client realm import Feb 23, 2024
@tobybellwood tobybellwood merged commit 17e0d56 into main Feb 23, 2024
1 check passed
@tobybellwood tobybellwood deleted the keycloak-realm-import-account branch March 13, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobybellwood tobybellwood tobybellwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shreddedbacon @tobybellwood