Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use email address instead of username when looking up users #3657

Merged
merged 1 commit into from
Mar 4, 2024
Merged

fix: use email address instead of username when looking up users #3657

merged 1 commit into from
Mar 4, 2024

Conversation

shreddedbacon
Copy link
Member

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

Just fixes the underlying resolvers and models to use the email address correctly.

Closing issues

closes #3656

@shreddedbacon shreddedbacon mentioned this pull request Feb 21, 2024
Merged
@shreddedbacon shreddedbacon added this to the 2.18.0 milestone Feb 21, 2024
@shreddedbacon shreddedbacon marked this pull request as ready for review February 21, 2024 08:26
@shreddedbacon shreddedbacon mentioned this pull request Feb 21, 2024
Closed
rocketeerbkw
rocketeerbkw approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@rocketeerbkw rocketeerbkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There shouldn't be any other issues with this.

@tobybellwood tobybellwood merged commit e836082 into main Mar 4, 2024
1 check passed
@tobybellwood tobybellwood deleted the use-email-not-username branch March 13, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rocketeerbkw rocketeerbkw rocketeerbkw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.18.0
Development

Successfully merging this pull request may close these issues.

Changing email address has unintended side effects
3 participants
@shreddedbacon @rocketeerbkw @tobybellwood