Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: realm import with missing roles and client information #3680

Merged
merged 2 commits into from
Mar 24, 2024

Conversation

shreddedbacon
Copy link
Member

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

There was some missing information for the opensearch-sync client. This updates the realm import to include this additional missing data that would have been created by this

Unfortunately this also restructured the JSON data considerably while diffing the missing opensearch sync components.

@shreddedbacon shreddedbacon added this to the 2.18.0 milestone Mar 15, 2024
@shreddedbacon shreddedbacon marked this pull request as ready for review March 15, 2024 07:56
tobybellwood added a commit that referenced this pull request Mar 18, 2024
@tobybellwood
Copy link
Member

I made a branch and used a tool to deep alphabet sort the json (https://novicelab.org/jsonabc/) - you can see the diff here
f553d91

Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

safe enough in this pre-release phase.

@tobybellwood tobybellwood merged commit 602ca7a into main Mar 24, 2024
1 check passed
@tobybellwood tobybellwood deleted the sync-realm-import branch March 24, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants