Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: validate migrating labels for active standby ingress migrations #3682

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

shreddedbacon
Copy link
Member

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

This refactors the activestandby task to perform validations of the migrating status label before migrations take place. It ensures that the label exists on the resources before they are migrated, and then post migration ensures that the label is reset.

This is done to help prevent the potential for race condition between the label being added to the ingress right before the migration of that ingress takes place.

@shreddedbacon shreddedbacon added this to the 2.18.0 milestone Mar 21, 2024
@shreddedbacon shreddedbacon changed the title refactor: validate migrating label before and after migrations Improvement: validate migrating labels for active standby ingress migrations Mar 21, 2024
@shreddedbacon shreddedbacon marked this pull request as ready for review March 21, 2024 07:03
@shreddedbacon shreddedbacon force-pushed the activestandby-validations branch from 0658324 to a77afa8 Compare March 24, 2024 23:00
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing has shown a minimization of race condition occurrence with the additional validation steps. We should still consider configuring external tooling to mitigate any risk of future race conditions

(edited to reflect minimization instead of elimination)

@shreddedbacon
Copy link
Member Author

Just to clarify, it doesn't eliminate the potential for a race

@tobybellwood tobybellwood merged commit 1ef2da0 into main Mar 26, 2024
1 check passed
@tobybellwood tobybellwood deleted the activestandby-validations branch March 26, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants