Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use utf8 instead of ascii when retrieving logs #3737

Merged
merged 1 commit into from
Jun 12, 2024
Merged

fix: use utf8 instead of ascii when retrieving logs #3737

merged 1 commit into from
Jun 12, 2024

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Jun 11, 2024 •
edited
Loading

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

Changes the log encoding to UTF8 instead of ASCII so the UI will display special characters correctly

image

Closing issues

closes #3398

@shreddedbacon shreddedbacon added this to the 2.20.0 milestone Jun 11, 2024
@shreddedbacon shreddedbacon marked this pull request as ready for review June 11, 2024 22:44
tobybellwood
tobybellwood approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward enough, easy fix.

@tobybellwood tobybellwood merged commit 897a7aa into main Jun 12, 2024
1 check passed
@shreddedbacon shreddedbacon deleted the special-chars-in-logs branch June 12, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobybellwood tobybellwood tobybellwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.20.0
Development

Successfully merging this pull request may close these issues.

Special characters in build logs are not properly displayed
2 participants
@shreddedbacon @tobybellwood