fix: remove usergroup injection from org project groups to prevent duplicates #3744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
force-pushed
the
fix-organization-groups
branch
from
e72f4f7 to
b87e93d
Compare
shreddedbacon
force-pushed
the
fix-organization-groups
branch
from
b87e93d to
6fb6812
Compare
tobybellwood
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Checklist
Database Migrations
If an organization owner was a member of a group and also the organization owner, when viewing the groups of a project it would result in duplicate groups appearing due to the way the resolver consolidated groups.
This fix is to remove the part of the resolver where the users groups are injected into the resulting projects groups so that only groups attached to the project are returned.
Due to the way groups work in Lagoon prior to organizations, there exists the possibility that a group that did not exist within the organization could have been attached to a project, however this is unlikely (but not impossible)